Convenience update #2
Conversation
Specifically desired resources can be added to the repository regardless with e.g. `git add --force Data/...`.
…ng HRTF if already present
(no changes to code)
…set the current folder on execution
…x is unavailable
…mpling frequency for allpass filters
(also remove parallelisation from export loop in `Demo_BinauralSDM_QuantizedDOA_andRTModAP.m` since it was slower as it is not CPU bound)
…and right channel HRIRs stacked in single variable (also rename variables from HRTF into HRIR in most places, since that is what they are ...)
- Filters are now applied before splitting (time windowing) of the BRIRs - Extracted from example script into separate function
…and early reflection BRIRs optional
(for that, adjust the way other plot strings are escaped)
facebook-github-bot
added
the
CLA Signed
|
The changelog has been added in the last two commits. |
|
Hi @HaHeho! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
(I'm sorry that this probably breaks git blame)
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
(I'm sorry that this probably breaks git blame)
…ed by default over exporting individual WAV-files with according changes for new flags in `create_BRIR_data.m`)
HaHeho
force-pushed
the
wip-convenience-update
branch
from
b7ffbf2
to
640ad70
Compare
|
BTW, we can add some git release tags in the repository, to provide backwards compatibility for older code bases that rely on the initial implementation of this repository. In this way, the older versions can be downloaded from a specific URL or directly via the release section of the repository. That could make it easier to provide compatibility for internal projects. |
|
Hi Hannes, That's a good idea. I would suggest that we tag the current main branch (with a last commit on 17/November/2021 as v0.1, we then merge this branch and we tag it as v0.5. I would like to add the following before a v1 release:
What do you think? |
|
I just accepted the pull request. I am not fully done with the review and might commit some changes on top, but I think the benefit of the merging without more delays and your additions outweigh the impact of any potential modifications. |
|
That's great. Thank for merging. :)
I usually prefer version numbers and tags with dates, e.g. v2022-08-30. I find it more meaningful than some arbitrary version number.
Having those would for sure be nice. :) |
|
@svamengualgari you created the v.0.1 tag but not the v0.5 tag yet. Should I just add it to the last commit? |
I remembered this just now and noticed that I was able to create the tag and draft the according release. So I did. :) |
|
Ah, thanks a lot! The repo needs a bit of love and attention, but I'm quite
loaded with many other things... We did some good progress with Nils on two
of the open issues (EDC equalization and rendering of loudspeaker signals)
and hopefully we'll be able to push the changes in the next few weeks.
Your contributions were quite an improvement over the initial release, so
if you have more ideas or suggestions feel free to open new issues and I'll
try to slowly address them.
PS: That 2:08am DAGA conference Github release. I love it, conference
motivation :)
Best,
Sebastia
Missatge de Hannes Helmholz ***@***.***> del dia dc., 8 de
març 2023 a les 2:08:
… @svamengualgari <https://github.com/svamengualgari> you created the v.0.1
tag but not the v0.5 tag yet. Should I just add it to the last commit?
I remembered this just now and noticed that I was able to create the tag
and draft the according release. So I did. :)
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNZTF3LGZNGUVWUX7O7EJTW27LXXANCNFSM5SZJV66A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Sebastià V. Amengual Garí
|
A summarising changelog will follow.