This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Remove local_variables from on_end #414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: local_variables makes the code in train_step really hard to read. Killing it from all hooks will take time, so start from a single hook (on_step). Differential Revision: D20171981 fbshipit-source-id: 92bc3536780e56ac65c8eb7514c05a8f0a84b153
Differential Revision: D20170006 fbshipit-source-id: abdf5229832896f3e264e21cbd33493680116560
Summary: This is part of a series of diffs to eliminate local_variables (see D20171981). Proceed remobing local_variables from on_start Differential Revision: D20178165 fbshipit-source-id: 10f2ebcd7fc9044d7dfb86384f504ae3798c4930
Summary: This is part of a series of diffs to eliminate local_variables (see D20171981). Proceed removing local_variables from on_end Differential Revision: D20178202 fbshipit-source-id: 2fa1495fcf35698eebea636b6f61789343144c1e
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D20178202 |
|
This pull request has been merged in 404b325. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is part of a series of diffs to eliminate local_variables (see D20171981).
Proceed removing local_variables from on_end
Differential Revision: D20178202