-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix .clone() to .copy() for AutogradBatchNorm #21
fix .clone() to .copy() for AutogradBatchNorm #21
Conversation
Hi Farbdrucker! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Good catch, thanks! Please note that there are a few more outstanding issues with batch normalization in training mode (see the commented out code below), so I don't expect it will work correctly for training at the moment. Please also note that the unit tests for batch normalization are disabled because of these issues. They need to be added in |
Thanks! Just noticed this obvious one.
good to know since this came up when I used the resnet18 like in your imagenet example Cheers |
@Farbdrucker Can you please sign the CLA so that we can merge your PR? |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubho is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Docs change / refactoring / dependency upgrade ## Motivation and Context / Related issue ## How Has This Been Tested (if it applies) ## Checklist - [ ] The documentation is up-to-date with the changes I made. - [ ] I have read the **CONTRIBUTING** document and completed the CLA (see **CONTRIBUTING**). - [ ] All tests passed, and additional code has been covered with new tests. Pull Request resolved: facebookresearch/CrypTen#21 Differential Revision: D18122999 Pulled By: shubho fbshipit-source-id: de50b3b2e473b7a95086cfa25c80501cd3921876
Types of changes
Motivation and Context / Related issue
How Has This Been Tested (if it applies)
Checklist