-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2314 +/- ##
==========================================
- Coverage 30.64% 23.35% -7.29%
==========================================
Files 595 578 -17
Lines 62959 62529 -430
Branches 10070 10023 -47
==========================================
- Hits 19296 14606 -4690
- Misses 42262 46984 +4722
+ Partials 1401 939 -462
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
parlai/tasks/dstc7/agents.py
Outdated
@@ -96,6 +99,17 @@ def share(self): | |||
return shared | |||
|
|||
|
|||
class DSTC7TeacherAugmented(DSTC7Teacher): | |||
""" | |||
Augmented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add more detail in this docstring? what does augmented mean? what is the difference between augmented and augmented sampled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be honest, @samhumeau would have a better idea of what exactly this means. I will consult him offline (unless he wants to comment here 😄)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah expand that docstring like emily says
Updated the docstring after consulting @samhumeau, will merge when tests pass. |
* updates to dstc7 task * black * update docstring
* updates to dstc7 task * black * update docstring
Patch description
The DSTC7 Augmented Sampled teacher was using a different train set than the one we used in the Poly-encoder paper; this PR fixes that.
Also a small fix to use the data in
shared
.Fix for #2306
Testing steps
I trained a poly-encoder model and got similar results to those in the paper.
Logs