Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Start always with human when no topic is selected. Else it gives erro… #3100

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

pushpendradahiya
Copy link
Contributor

Always start with the human when no topic (Option E) is selected in Interactive mode. Else it gives error since no text to process if the bot goes first (i.e. 50% time).

Patch description
WoW throws an error of "no text" 50% of the time, when option E is selected, i.e. No Topic

Testing steps
You can now run WoW scripts with WoW tasks in interactive mode and it will always run with option E selected. Which was happening earlier randomly 50% of the time.

Logs
parlai interactive -t wizard_of_wikipedia:generator -mf zoo:wizard_of_wikipedia/end2end_generator/model

Then select option E.

…r since no text to process if bot goes first (50% time).
@facebook-github-bot
Copy link

Hi @pushpendradahiya!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@stephenroller
Copy link
Contributor

Not sure about this but will defer to Kurt

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@github-actions
Copy link

This PR has not had activity in 30 days. Closing due to staleness.

Copy link
Contributor

@klshuster klshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this makes sense to me

@klshuster
Copy link
Contributor

thanks!

@stephenroller stephenroller merged commit ceb1fc4 into facebookresearch:master Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants