This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Check chat data folder validity #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klshuster
approved these changes
Jan 15, 2021
| @@ -188,6 +188,15 @@ def assert_task_args( | |||
| full_path | |||
| ), f"Target left pane text path {full_path} doesn't exist" | |||
|
|
|||
| if args.blueprint.get("chat_data_folder") == '': | |||
| raise ValueError('Must provide a valid chat data folder') | |||
| else: | |||
There was a problem hiding this comment.
you probably dont need the else here
There was a problem hiding this comment.
fair - changed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Ensure that a ~ doesn't exist in the model chat chat_data_folder param, because it currently can't be parsed
Testing steps
Existing CI checks