Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a bug in filter_results_by_id and a bug for saving optimizer (consolidate_state_dict) #8

Merged
merged 2 commits into from
Apr 30, 2023
Merged

fix a bug in filter_results_by_id and a bug for saving optimizer (consolidate_state_dict) #8

merged 2 commits into from
Apr 30, 2023

Conversation

jeffhj
Copy link
Contributor

@jeffhj jeffhj commented Mar 7, 2023 •
edited
Loading

Should return top k passages here; otherwise, may retrieve more than k passages

@facebook-github-bot
Copy link

Hi @jeffhj!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@jeffhj jeffhj changed the title fix a bug in filter_results_by_id fix a bug in filter_results_by_id and a bug for saving optimizer (consolidate_state_dict) Mar 7, 2023
@jeffhj
Copy link
Contributor Author

jeffhj commented Mar 7, 2023

consolidate_state_dict should be run on all ranks; otherwise, the program will hang when saving optimizer

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2023
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

3 similar comments
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@jeffhj jeffhj mentioned this pull request Mar 12, 2023
Closed
@mlomeli1 mlomeli1 merged commit 4a754cc into facebookresearch:main Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlomeli1 mlomeli1 mlomeli1 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffhj @facebook-github-bot @mlomeli1