Update implementation of scaled_index_add and index_select_cat #195
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allback Add a check for the proper size and type for the optimized scaled_index_add and index_select_cat, and fallback on pytorch implementation otherwise
facebook-github-bot
added
the
CLA Signed
|
@qasfb thanks for this. Are you planning to take this PR out of draft mode and have it reviewed/merged? Would be nice to see this land. |
| @@ -27,8 +27,26 @@ | |||
| XFORMERS_ENABLED = os.environ.get("XFORMERS_DISABLED") is None | |||
| try: | |||
| if XFORMERS_ENABLED: | |||
| from xformers.ops import fmha, scaled_index_add, index_select_cat | |||
|
|
|||
| from xformers.ops import scaled_index_add as _scaled_index_add, index_select_cat as _index_select_cat | |||
There was a problem hiding this comment.
Suggested change
| from xformers.ops import scaled_index_add as _scaled_index_add, index_select_cat as _index_select_cat | |
| from xformers.ops import fmha, scaled_index_add as _scaled_index_add, index_select_cat as _index_select_cat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check for the proper size and type for the optimized scaled_index_add and index_select_cat, and fallback on pytorch implementation otherwise