Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

[be]More robust upload for large files using multipart form data; [feat] better management of submission files; [be]some be abstrations; [feat] progress bar for upload #92

Merged
merged 4 commits into from
Jun 28, 2021

Conversation

mazhiyi
Copy link
Contributor

@mazhiyi mazhiyi commented Jun 28, 2021

  • [BE] Use multipart form data upload to resolve upload errors (a formal requests way to fix the issue in use curl for uploading models #79), and also works better for large file submissions
    • Specifically, tested for both 3GB and 6GB submissions on my local machine and didn't have a problem
  • [feat] Better management of submission files as requested in Submission Limit Exceeded Warning: Provide Additional Details #83:
    • Submissions are now saved to .dynalab_submissions and excluded from future submissions
    • Submission files are named as "date-filename.tar.gz` in the submissions folder
  • [BE] BE abstractions: avoid explicit use of ".dynalab" everywhere and instead getting it from config_handler.dynalab_dir
  • [feat] Also implemented the progress bar. Although since after uploading, there's also a transfer to S3 which we cannot access from locally, which means if you upload a big file, the progress bar will be stuck at 100% for a while when it's being further uploaded to S3)
  % dynalab-cli upload -n zm-test-large-mm100-175m-gpu              !10287
Config file validated
Tarballing the project directory...
Uploading files to S3. For large submissions, the progress bar may hang a while even after uploading reaches 100%. Please do not kill it...
upload: 100%|█████████████████████████| 1.50G/1.50G [00:30<00:00, 52.8MB/s]
Failed to submit model zm-test-large-mm100-175m-gpu due to submission limit exceeded. No more than 3 submissions allowed every 24 hours for task flores_small1.
You can inspect the prepared model submission locally at .dynalab_submissions/Jun-28-2021-15-36-43-zm-test-large-mm100-175m-gpu.tar.gz

Also uploaded a ~6G file to devserver, no problem

  % dynalab-cli upload -n zm-test-large-mm100-175m-gpu              !10364
Config file validated
Tarballing the project directory...
Uploading files to S3. For large submissions, the progress bar may hang a while even after uploading reaches 100%. Please do not kill it...
Upload: 100%|█████████████████████████| 5.98G/5.98G [31:52<00:00, 3.35MB/s]
Your model zm-test-large-mm100-175m-gpu has been uploaded to S3 and will be deployed shortly. You will get an email notification when your model is available on Dynabench.
You can inspect the prepared model submission locally at .dynalab_submissions/Jun-28-2021-18-47-56-zm-test-large-mm100-175m-gpu.tar.gz

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 28, 2021
@mazhiyi mazhiyi linked an issue Jun 28, 2021 that may be closed by this pull request
@mazhiyi mazhiyi changed the title More robust upload using multipart form data; better management of submission files; some be abstrations More robust upload for large files using multipart form data; better management of submission files; some be abstrations Jun 28, 2021
@mazhiyi
Copy link
Contributor Author

mazhiyi commented Jun 28, 2021

cc @gwenzek

@mazhiyi mazhiyi changed the title More robust upload for large files using multipart form data; better management of submission files; some be abstrations [be]More robust upload for large files using multipart form data; [feat] better management of submission files; [be]some be abstrations Jun 28, 2021
@mazhiyi mazhiyi marked this pull request as ready for review June 28, 2021 13:29
@mazhiyi mazhiyi changed the title [be]More robust upload for large files using multipart form data; [feat] better management of submission files; [be]some be abstrations [be]More robust upload for large files using multipart form data; [feat] better management of submission files; [be]some be abstrations; [feat] progress bar for upload Jun 28, 2021
@mazhiyi mazhiyi linked an issue Jun 28, 2021 that may be closed by this pull request
Copy link
Contributor

@TristanThrush TristanThrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mazhiyi mazhiyi mentioned this pull request Jun 28, 2021
@mazhiyi mazhiyi linked an issue Jun 28, 2021 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large Size Model > 2GB Better management of submitted files Progress bar for uploading to S3
3 participants