[chore] update to torch v1.8.0 #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
min-xu-ai
approved these changes
Mar 10, 2021
msbaines
force-pushed
the
torch18
branch
12 times, most recently
from
3e6752c
to
abe2628
Compare
blefaudeux
reviewed
Mar 11, 2021
| @@ -146,12 +146,17 @@ def dist_init(rank: int, world_size: int, filename: str, filename_rpc: str = "") | |||
|
|
|||
| torch.distributed.init_process_group(backend=backend, rank=rank, world_size=world_size, init_method=url) | |||
|
|
|||
| tp_options = {"init_method": url_rpc} | |||
| # Workaround for bug in torch v1.8.0. Should be fixed in v1.8.1 | |||
There was a problem hiding this comment.
oh wow, thanks for catching that
blefaudeux
approved these changes
Mar 11, 2021
msbaines
force-pushed
the
torch18
branch
7 times, most recently
from
9f9e800
to
3403be1
Compare
msbaines
force-pushed
the
torch18
branch
6 times, most recently
from
8c12480
to
301756c
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃