-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Add the latest numpy version to requirements.txt #731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is conflicting with fairseq on Python 3.6: I am not sure what is the reason for the restriction there, but requiring 1.21 is breaking fairseq right now. |
More info: This diff makes Python 3.7 a hard requirement for fairscale, and thus for fairseq which depends on it. Since the motivation here seems to be typing, I don't think it's worth changing the minimal supported Python version for fairseq and fairscale for it. |
I get an uneasy feeling thinking that the CI will test on versions other than the official minimal versions. |
Thank you for the headsup @omry As you can see in the PR description I am still debugging why some users ran into this. This was only a quick fix to unblock users. |
What does this PR do?
Certain PRs (looks like forks) are running into mypy errors due to a bumped up numpy version that is being pulled in.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.