Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add size method to BacktranslationDataset + misc fixes #325

Closed
wants to merge 2 commits into from
Closed

Add size method to BacktranslationDataset + misc fixes #325

wants to merge 2 commits into from

Commits on Oct 23, 2018

  1. Expose BacktranslationDataset from fairseq.data 

    Summary: BacktranslationDataset was introduced in D9478258 but the dataset itself was not exposed as part of the fairseq.data module in D9930786

Differential Revision: D10412717

fbshipit-source-id: 68ff636bb9c081fdc081d5818241d96c1672235c
    @facebook-github-bot
    Deepak Gopinath authored and facebook-github-bot committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    6c91751 View commit details
    Browse the repository at this point in the history

  2. Add size method to BacktranslationDataset + misc fixes 

    Summary: RoundRobinZipDataset requires size(index) method implemented in every dataset used. Also added missing return statements in a few methods.

Reviewed By: liezl200

Differential Revision: D10457159

fbshipit-source-id: 6fefddd6b9980a139a8bb8ac2c94217db6e17fb9
    @facebook-github-bot
    Deepak Gopinath authored and facebook-github-bot committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    1c79b2f View commit details
    Browse the repository at this point in the history