Versioning #124
Merged
Versioning #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
| > the fairseq2n installation command above to get the most up-to-date binary. If | ||
| > you observe runtime or test failures after the installation, it might be | ||
| > because the latest nightlies are not published yet. If the problem persists | ||
| > after about 12 hours, please create a GitHub issue. |
There was a problem hiding this comment.
Nit but we can add a link to make the issue here
There was a problem hiding this comment.
Makes sense. Let me put a link tomorrow.
There was a problem hiding this comment.
Ok, made the changes along with PyTorch 2.1 updates. Please see the latest version of the doc.
| @@ -81,7 +81,7 @@ brew install libsndfile | |||
|
|
|||
| ### 3.2 PyTorch | |||
| Follow the instructions on [pytorch.org](https://pytorch.org) to install the | |||
| desired PyTorch version. Note that fairseq2 supports only PyTorch 1.12 or | |||
| desired PyTorch version. | |||
There was a problem hiding this comment.
Shouldnt we specify the min version it supports?
There was a problem hiding this comment.
I am working on PyTorch 2.1 builds right now, and plan to consolidate all version information in README to reduce the maintenance overhead.
There was a problem hiding this comment.
Ok, put a link here to the supported version list in README (see latest version). Thanks again for the feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revises the version handling of fairseq2. Instead of using the latest stable fairseq2n package, we now use the latest nightly fairseq2n which circumvents a cmake build as long as nightlies are up-to-date with HEAD. The catch is that we should regularly publish nightlies. In particular any changes in fairseq2n that introduces a new feature or a BC-breaking change should be followed by a nightly build/publish.