Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover more types for C_API #1917

Closed
wants to merge 5 commits into from
Closed

Conversation

ava57r
Copy link
Contributor

@ava57r ava57r commented May 28, 2021

Exported some global variables and statistics.
Supported downcast for IndexIDMap and IndexIDMap2 from faiss::Index
Fixes #1863

@mdouze
Copy link
Contributor

mdouze commented Jun 2, 2021

Sounds good. Maybe @Enet4 wants to take a look?

@facebook-github-bot
Copy link
Contributor

@mdouze has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. All I found was a few extraneous words in the documentation blocks.

c_api/MetaIndexes_c.h Outdated Show resolved Hide resolved
c_api/MetaIndexes_c.h Outdated Show resolved Hide resolved
Co-authored-by: Eduardo Pinho <enet4mikeenet@gmail.com>
@facebook-github-bot
Copy link
Contributor

@mdouze has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mdouze merged this pull request in f6d2efd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export global vars into c_api
4 participants