Missed printing 'D' #3433
Missed printing 'D' #3433
Conversation
|
Hi @saarthdeshpande! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tutorial/cpp/6-HNSW.cpp
Outdated
| for (int i = nq - 5; i < nq; i++) { | ||
| for (int j = 0; j < k; j++) | ||
| printf("%5zd ", I[i * k + j]); | ||
| printf("%5zd ", D[i * k + j]); |
There was a problem hiding this comment.
Format specifies type 'ssize_t' (aka 'long') but the argument has type 'float' [-Werror,-Wformat]
printf("%5zd ", D[i * k + j]);
~~~~ ^~~~~~~~~~~~
%5f
There was a problem hiding this comment.
@saarthdeshpande would you like to fix this part?
There was a problem hiding this comment.
Done! Added the changes for other tutorial files too.
'I' was printed twice and 'D' was not printed. Fixed.
The index search operation was repeated, and nlist isn't used in HNSW.
|
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: 'I' was printed twice and 'D' (distance vector) was not printed. Fixed. Pull Request resolved: facebookresearch#3433 Reviewed By: fxdawnn Differential Revision: D57451544 Pulled By: junjieqi fbshipit-source-id: fc17b3b467f8b2c4ad7d80b44866456d9146e530
Summary: 'I' was printed twice and 'D' (distance vector) was not printed. Fixed. Pull Request resolved: facebookresearch#3433 Reviewed By: fxdawnn Differential Revision: D57451544 Pulled By: junjieqi fbshipit-source-id: fc17b3b467f8b2c4ad7d80b44866456d9146e530
'I' was printed twice and 'D' (distance vector) was not printed. Fixed.