Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix annotation extraction #310

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Fix annotation extraction #310

merged 2 commits into from
Jun 14, 2023

Conversation

mmuckley
Copy link
Contributor

Fixes #309 by using out-of-place updates for raw_samples in AnnotatedSliceDataset.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 14, 2023
@mmuckley mmuckley mentioned this pull request Jun 14, 2023
Closed
Duplums
Duplums approved these changes Jun 14, 2023
View reviewed changes
Copy link

@Duplums Duplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should solve the issue since metadata is updated with a deep copy for each slice. It is also clearer since it avoids adding another attribute annotated_raw_samples. get_annotation is updated for clarity in this PR.

@mmuckley mmuckley merged commit cc42bc3 into main Jun 14, 2023
@mmuckley
Copy link
Contributor Author

Thanks for checking @Duplums. I moved a deepcopy to the start of the annotation logic to try to make it a bit more clean. I'll go ahead and merge this fix and push a bug release to PyPI next week. Feel free to open another PR if you notice anything to follow-up.

@mmuckley mmuckley deleted the mmuckley/annotated_update branch June 14, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duplums Duplums Duplums approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong annotations in AnnotatedSliceDataset
3 participants
@mmuckley @Duplums @facebook-github-bot