-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add feature varnet #340
add feature varnet #340
Conversation
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly asking for small reformatting items.
fastmri_examples/feature_varnet/pl_modules/feature_varnet_module.py
Outdated
Show resolved
Hide resolved
Also @GiannakopoulosIlias it looks like the PR is failing some linter tests. Could you also fix those? |
@GiannakopoulosIlias some tests still aren't passing. Please make sure you're using the correct version of |
@GiannakopoulosIlias the message about Jupyter can be ignored. You only need to |
Should be okay now, thanks! |
Hello @GiannakopoulosIlias, now it looks like there are errors with type annotations with mypy. If there are too many to deal with, you could move |
I will try to adjust them tomorrow. They look many but I think most of them are the same error for all different model ablations. |
…stalled black 22.3.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with fixes for moving the feature_varnet.py
to fastmri_examples
.
Added a new folder in fastmri_examples which includes the new modules for feature varent and ablations.
Added a new model file (feature_varnet) in fastmri/models which includes the new models.
Updated markdowns to include the new reference.