Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature varnet #340

Merged
merged 11 commits into from
Jul 23, 2024
Merged

Conversation

GiannakopoulosIlias
Copy link
Contributor

Added a new folder in fastmri_examples which includes the new modules for feature varent and ablations.
Added a new model file (feature_varnet) in fastmri/models which includes the new models.
Updated markdowns to include the new reference.

@facebook-github-bot
Copy link

Hi @GiannakopoulosIlias!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 23, 2024
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Contributor

@mmuckley mmuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly asking for small reformatting items.

fastmri/models/feature_varnet.py Outdated Show resolved Hide resolved
fastmri_examples/feature_varnet/pl_modules/__init__.py Outdated Show resolved Hide resolved
@mmuckley
Copy link
Contributor

Also @GiannakopoulosIlias it looks like the PR is failing some linter tests. Could you also fix those?

@mmuckley
Copy link
Contributor

@GiannakopoulosIlias some tests still aren't passing. Please make sure you're using the correct version of black on your code.

@mmuckley
Copy link
Contributor

@GiannakopoulosIlias the message about Jupyter can be ignored. You only need to pip install black with the right version listed in the message.

@GiannakopoulosIlias
Copy link
Contributor Author

@GiannakopoulosIlias the message about Jupyter can be ignored. You only need to pip install black with the right version listed in the message.

Should be okay now, thanks!

@mmuckley
Copy link
Contributor

Hello @GiannakopoulosIlias, now it looks like there are errors with type annotations with mypy.

If there are too many to deal with, you could move feature_varnet.py into the examples folder. Then you should be able to commit the code without fixing everything.

@GiannakopoulosIlias
Copy link
Contributor Author

Hello @GiannakopoulosIlias, now it looks like there are errors with type annotations with mypy.

If there are too many to deal with, you could move feature_varnet.py into the examples folder. Then you should be able to commit the code without fixing everything.

I will try to adjust them tomorrow. They look many but I think most of them are the same error for all different model ablations.

Copy link
Contributor

@mmuckley mmuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with fixes for moving the feature_varnet.py to fastmri_examples.

@mmuckley mmuckley merged commit b661598 into facebookresearch:main Jul 23, 2024
5 checks passed
@mmuckley mmuckley mentioned this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants