Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX]Remove redundant method refs in log messages #1432

Merged
merged 3 commits into from
Aug 11, 2021

Conversation

jturner65
Copy link
Contributor

Motivation and Context

With the most recent logging functionality, filename, source function, and line number for logging message is provided automatically. This PR removes some remaining log messages that were also including this information, which is now redundant.

How Has This Been Tested

Locally, c++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 11, 2021
@jturner65 jturner65 requested review from Skylion007, erikwijmans and aclegg3 and removed request for Skylion007 August 11, 2021 17:58
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the clean-up.

@jturner65 jturner65 merged commit 1a0a364 into facebookresearch:master Aug 11, 2021
@jturner65 jturner65 deleted the Bugfix_MissedLogMsg branch August 11, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants