Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI]: update codecov to use binary + fix ccache #1470

Merged
merged 7 commits into from
Sep 9, 2021
Merged

[CI]: update codecov to use binary + fix ccache #1470

merged 7 commits into from
Sep 9, 2021

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • The current bash uploader for CodeCov is deprecated. This fixes it to use the new binary version.
  • Also tries to fix ccaching since the caches are now immutable.

How Has This Been Tested

  • CI

Types of changes

  • Docs change / refactoring / dependency upgrade

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 9, 2021
jturner65
jturner65 approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Skylion007 Skylion007 changed the title CI update codecov to use binary [CI]: update codecov to use binary + fix ccache Sep 9, 2021
@Skylion007 Skylion007 merged commit f20d682 into master Sep 9, 2021
@Skylion007 Skylion007 deleted the ci_update_codecov branch September 9, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 approved these changes

@mathfac mathfac Awaiting requested review from mathfac

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@eundersander eundersander Awaiting requested review from eundersander

@erikwijmans erikwijmans Awaiting requested review from erikwijmans

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Skylion007 @jturner65 @facebook-github-bot