Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added path arg to load_nav_mesh #1503

Merged
merged 1 commit into from
Sep 29, 2021
Merged

added path arg to load_nav_mesh #1503

merged 1 commit into from
Sep 29, 2021

Conversation

naokiyokoyama
Copy link
Contributor

@naokiyokoyama naokiyokoyama commented Sep 28, 2021 •
edited by erikwijmans

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@naokiyokoyama naokiyokoyama mentioned this pull request Sep 28, 2021
Closed
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 28, 2021
erikwijmans
erikwijmans approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@erikwijmans erikwijmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to support named arguments. But just to be clear, it supports positional arguments as is.

@erikwijmans erikwijmans linked an issue Sep 28, 2021 that may be closed by this pull request
Load Navmesh PyBind missing an argument #1502
Closed
@erikwijmans
Copy link
Contributor

Closes #1502

@Skylion007 Skylion007 merged commit 8529f11 into facebookresearch:main Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@erikwijmans erikwijmans erikwijmans approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load Navmesh PyBind missing an argument
4 participants
@naokiyokoyama @erikwijmans @Skylion007 @facebook-github-bot