Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI]: Quickfix the CI by updating certificates #1518

Merged
merged 8 commits into from
Oct 5, 2021
Merged

[CI]: Quickfix the CI by updating certificates #1518

merged 8 commits into from
Oct 5, 2021

Conversation

Skylion007
Copy link
Contributor

@Skylion007 Skylion007 commented Oct 5, 2021 •
edited by JuanTheEngineer

Motivation and Context

  • Fixes the CI without upgrading to the latest Ubuntu and all the possible changes that come with it.
  • Alternative to [CI] Fix the CI! #1516

How Has This Been Tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • All new and existing tests passed.

@Skylion007 Skylion007 mentioned this pull request Oct 5, 2021
Closed
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 5, 2021
@erikwijmans
Copy link
Contributor

Looks like you need to move . ~/emsdk/emsdk_env.sh after the nvm command also.

jturner65
jturner65 approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very nice.

erikwijmans
erikwijmans approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@erikwijmans erikwijmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's ship this. The other one also includes some code changes

@Skylion007 Skylion007 merged commit d3a4b4a into main Oct 5, 2021
@Skylion007 Skylion007 deleted the fix_rootca_quickfix branch October 5, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 approved these changes

@erikwijmans erikwijmans erikwijmans approved these changes

@mathfac mathfac Awaiting requested review from mathfac

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@eundersander eundersander Awaiting requested review from eundersander

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Skylion007 @erikwijmans @jturner65 @facebook-github-bot