Use a newer pip so the MacOS wheel gets installed #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
approved these changes
Oct 6, 2021
facebook-github-bot
added
the
CLA Signed
|
With this change, I'm still seeing local crash running pre-commit hook building clang-format. Relevant line seems to indicate that our configured cmake version is too old. |
|
@aclegg3 I'm gonna land this as I think your error likely requires a different fix. |
|
Why is it building? It should not be building as long as pip is new enough (unless you are on Alpine, though that will be fixed soon). The CMake version is also fixed in master and will be in the next release, but it really shouldn't be building locally. |
|
At least for me it was building because the pip pre-commit uses in its venv was 20 and that doesn't recognize the universal2 tag. |
JuanTheEngineer
pushed a commit
that referenced
this pull request
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The MacOS wheel for clang-format requires pip>=21 to be installed (and building all of llvm is no fun).
How Has This Been Tested
Locally.
Types of changes
Bug fix (non-breaking change which fixes an issue)