--Support multi-color gradient trajectories #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interpolate a list of colors (in HSV space) of any length and map them to trajectory vertices; use vertex colors to render trajectory tube.
facebook-github-bot
added
the
CLA Signed
|
|
|
|
Skylion007
reviewed
Oct 25, 2021
src/esp/geo/Geo.cpp
Outdated
| std::vector<Mn::Vector3> trajColors; | ||
|
|
||
| // temp converter to vector of values in HSV space from RGB color | ||
| auto convertClrToHSVArray = [&](const Mn::Color3ub& clr) -> Mn::Vector3 { |
There was a problem hiding this comment.
Why the [&], can't this be a pure a lambda?
Skylion007
reviewed
Oct 25, 2021
src/esp/geo/Geo.cpp
Outdated
| vertices.slice(&Vertex::color); | ||
|
|
||
| // temp converter to RGB color from vector of HSV values | ||
| auto convertHSVArrayToColor = [&](const Mn::Vector3& hsvVec) -> Mn::Color3ub { |
There was a problem hiding this comment.
Likewise for this lambda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interpolate a list of colors (in HSV space) of any length and map them to trajectory vertices; use vertex colors to render trajectory tube.
Motivation and Context
This PR introduces the ability to generate trajectories with color gradients by interpolating a given list of colors (in HSV space) to produce per-trajectory prim ring colors that are then assigned to the vertices of the trajectory. Any number of colors are supported, not just 2.
The existing functionality is still supported, but another functional binding has been added that supports the user specifying a list of Mn::Color3ub values to be used as the color interpolants. NOTE : the existing code supported the user specifying a single Mn::Color4 (which was a float color w/alpha) even though the alpha was ignored for this construct. A discussion should be had on whether we wish to refactor the old mechanism to support Color3ub, dispose of the old method entirely, or leave the old method (to not break existing code).
How Has This Been Tested
Local c++ and python tests pass; Viewer.cpp has been expanded to enable the user to request a single random color or a random number of multiple random colors (up to 5) to illustrate the functionality.
Types of changes
Checklist