Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python Viewer Navmesh Visualization via Key Press Toggle #1555

Merged
merged 33 commits into from
Nov 8, 2021
Merged

Python Viewer Navmesh Visualization via Key Press Toggle #1555

merged 33 commits into from
Nov 8, 2021

Conversation

JuanTheEngineer
Copy link
Contributor

@JuanTheEngineer JuanTheEngineer commented Nov 1, 2021 •
edited
Loading

Motivation and Context

This PR migrates the Navmesh Recompute and Toggle feature to the python viewer.

How Has This Been Tested

Building and running viewer.py

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 1, 2021
JuanTheEngineer and others added 14 commits November 2, 2021 11:16
@JuanTheEngineer
Resolving Review Changes
dc3be6a
@JuanTheEngineer
Add command-line args to accept filename, model data, and motion data
07330b0
@JuanTheEngineer
First draft of Save/Fetch methods and saving logic
69a5364
@JuanTheEngineer
Add Save file Key Press 'P' with several functionalities
b15584c
@JuanTheEngineer
Add Load/Fetch data from file Key Press 'L'
8adc7fa
@JuanTheEngineer
Debugging reconfigure
677f9f0
@JuanTheEngineer
Remove name key from data, and save and fetch including position data
a6f70ad
@JuanTheEngineer
Final Draft of Save\Load Functions
607c10a
@JuanTheEngineer
Fixing bug in python-viewer with draw event callable argument (#1558)
77bc7af
@jturner65 @JuanTheEngineer
[BugFix]--bypass test_sensor tests if no torch is found. (#1559)
8a2c654 
* --bypass test if no torch is found.
@JuanTheEngineer
Fairmotion Character Positioning via MOTION MouseMode (#1552)
c772968 
* Add MOTION mouse mode

* Create and Remove functions for selector icon

* Rotate and Translate feature in motion mode
@Skylion007 @mathfac @JuanTheEngineer
Build OSX Conda Nightly (#1430)
b2b3039 
* Refactor conda OSX into command

* Further parameterize the OSX conda build

* Update .circleci/config.yml

Co-authored-by: Oleksandr <maksymets.o@gmail.com>

* Fix missing conditional

* Add missing params

* Try to update and test CI upload

* Fix code change

* Further adjust matrix args

* Finalize nightly builds

* Add release tag config

Co-authored-by: Oleksandr <maksymets.o@gmail.com>
@JuanTheEngineer
Navmesh Recompute and Toggle
9ea6fc4
@JuanTheEngineer
Making recompute NavMesh occur on application start
503d594
@JuanTheEngineer JuanTheEngineer marked this pull request as ready for review November 4, 2021 14:56
aclegg3
aclegg3 approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fixes and ready to go.

examples/viewer.py Outdated Show resolved Hide resolved
examples/viewer.py Outdated Show resolved Hide resolved
@JuanTheEngineer JuanTheEngineer merged commit befcc53 into main Nov 8, 2021
@JuanTheEngineer JuanTheEngineer deleted the python-viewer branch November 8, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JuanTheEngineer @aclegg3 @Skylion007 @facebook-github-bot @jturner65