Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix/Refactor]--Acquire render context on object removal; Cleanup superfluous add objects #1581

Merged
merged 4 commits into from
Dec 2, 2021

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This small PR adds the acquisition of the render context when objects are deleted in PhysicsManager, as well as when Articulated Objects are created (necessary now since we no longer pass through Simulator to instantiate these objects). A few redundant "PhysicsManager::addObject" overloads were also removed.

How Has This Been Tested

C++ and python tests locally pass.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 1, 2021
@jturner65 jturner65 merged commit 19f9cb7 into facebookresearch:main Dec 2, 2021
@jturner65 jturner65 deleted the PM_BugfixRefactor branch December 2, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants