Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PyBind11 to v2.9.0 #1617

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Update PyBind11 to v2.9.0 #1617

merged 1 commit into from
Jan 10, 2022

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • Updates PyBind11 to the newest version which has better cmake, better kwargs handlings, bugfixes, and better support for newer Python versions.

How Has This Been Tested

  • Locally and via CI throughout PyBind11 version development

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 10, 2022
jturner65
jturner65 approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested things locally and looks good to me.

@Skylion007 Skylion007 merged commit ea1b300 into main Jan 10, 2022
@Skylion007 Skylion007 deleted the pybind11_update_290 branch January 10, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@eundersander eundersander Awaiting requested review from eundersander

@erikwijmans erikwijmans Awaiting requested review from erikwijmans

@vincentpierre vincentpierre Awaiting requested review from vincentpierre

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Skylion007 @jturner65 @facebook-github-bot