--Remove unused/superfluous dependency, Sophus #1639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR gets rid of a superfluous dependency, Sophus, which was accessed only in 1 place, building a Special Euclidean group transform (translate and rotate but no reflection) for Replica semantic object bounding boxes. The calc was easily replaced using Eigen Isometry transforms. A test was added to ReplicaSceneTest to verify that the results using Isometries are approximately the same result as what Sophus was giving us.
How Has This Been Tested
Types of changes
Checklist