Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--Remove unused/superfluous dependency, Sophus #1639

Merged
merged 6 commits into from
Jan 27, 2022

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Jan 27, 2022

Motivation and Context

This PR gets rid of a superfluous dependency, Sophus, which was accessed only in 1 place, building a Special Euclidean group transform (translate and rotate but no reflection) for Replica semantic object bounding boxes. The calc was easily replaced using Eigen Isometry transforms. A test was added to ReplicaSceneTest to verify that the results using Isometries are approximately the same result as what Sophus was giving us.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 27, 2022
@jturner65 jturner65 merged commit 1b81638 into facebookresearch:main Jan 27, 2022
@jturner65 jturner65 deleted the Deps_RemoveSophus branch January 27, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants