Python 3.7 upgrade #1647
Merged
Python 3.7 upgrade #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Skylion007
reviewed
Feb 2, 2022
| @@ -5,7 +5,7 @@ | |||
| [](https://anaconda.org/aihabitat/habitat-sim) | |||
| [](https://aihabitat.org/docs/habitat-sim/) | |||
| [](https://github.com/pre-commit/pre-commit) | |||
| [](https://www.python.org/downloads/release/) | |||
| [](https://www.python.org/downloads/release/) | |||
There was a problem hiding this comment.
We aren't enabling 3.9? Should work out of the box.
Skylion007
reviewed
Feb 2, 2022
| @@ -33,7 +33,7 @@ def call(cmd, env=None): | |||
|
|
|||
|
|
|||
| def get_default_modes_and_vers(): | |||
| py_vers = ["3.6", "3.7", "3.8"] | |||
| py_vers = ["3.7", "3.8"] | |||
|
|
||
| Once the package is built, make sure you're logged in to anaconda cloud and then run ```anaconda upload <path to the tarball file that conda build created>```. For exmaple ```anaconda upload hsim-macos/osx-64/habitat-sim-1.3.2-py3.6_osx.tar.bz2```. This will upload the package to anaconda cloud for everyone to download. |
There was a problem hiding this comment.
Maybe we should just replace the version info here with globs.
Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
…rch/habitat-sim into python-3.7-upgrade
…rch/habitat-sim into python-3.7-upgrade
jturner65
approved these changes
Feb 2, 2022
|
Thanks for the additional fixes, @Skylion007. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Python 3.6 is past end of life, time to upgrade.
How Has This Been Tested
CI
Types of changes
Checklist