Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix performance issues with calc MOBB #1648

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Fix performance issues with calc MOBB #1648

merged 1 commit into from
Feb 2, 2022

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

This fixes 2 minor performance issues.

  1. is that all std::vectors in this algorithm are of known sizes at runtime and should reserve the appropiate amount of heap space for their calculation
  2. There is an std::vector that was being treated more as a tuple. I replaced it with an std::array since the size is known at compile time.

How Has This Been Tested

  • PyTest and CI

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 2, 2022
jturner65
jturner65 approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Skylion007 Skylion007 merged commit 99c85b0 into main Feb 2, 2022
@Skylion007 Skylion007 deleted the calc-mobb-performance-fix branch May 5, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 approved these changes

@erikwijmans erikwijmans Awaiting requested review from erikwijmans

@aclegg3 aclegg3 Awaiting requested review from aclegg3

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Skylion007 @jturner65 @facebook-github-bot