Fix noise model #1684
Merged
Fix noise model #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Skylion007
reviewed
Mar 4, 2022
Skylion007
approved these changes
Mar 4, 2022
jturner65
pushed a commit
to jturner65/habitat-sim
that referenced
this pull request
Mar 18, 2022
* Fix redwood depth noise model * Fix redwood depth noise model * Set warp size too * Slight change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When matching the GPU to CPU implementation of the noise model, I copied over a bug from the CPU side.
This PR also fixes some other issues in the GPU implementation, like not writing the curand states back to global memory and gives each thread it's own state (that should have been done earlier, the CUDA docs are confusing on if they a thread safe or not but they aren't).
Closes #1455
How Has This Been Tested
Via the test.
Types of changes
Bug fix (non-breaking change which fixes an issue)