Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--Update Bullet to Bullet 3.22b #1723

Merged
merged 13 commits into from
Apr 12, 2022

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This PR updates our bullet dependency to version 3.22. This opens up access to bug fixes, expanded deformable support (including cloth), multibody functionality, etc added to support various paper-based implementations.

One interesting issue I ran during the process of updating was that this Bullet PR introduced an optimisation that causes erroneous rigid body behavior in our code., specifically this calculation here. The changes to our dependencies.cmake file allow for this optimisation to be bypassed.

How Has This Been Tested

All c++ and python tests pass locally.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 11, 2022
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM merge when tests pass.

@aclegg3
Copy link
Contributor

aclegg3 commented Apr 11, 2022

Not sure why the osx conda build isn't working here, but it doesn't seem like a result of this PR so we can probably ignore it.

@jturner65 jturner65 merged commit 2353ef9 into facebookresearch:main Apr 12, 2022
@jturner65 jturner65 deleted the Bullet_Update branch April 12, 2022 16:16
aclegg3 added a commit that referenced this pull request Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants