Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor perf fix in magnum-bindings buffer protocol #1731

Merged
merged 1 commit into from
Apr 24, 2022

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

How Has This Been Tested

  • Merged as part of magnum-bindings test suite. Should have little effect as the change is mostly internal and remove accidental non-trivial copies within pybind11. Should hopefully provide a very minor perf boost.

Types of changes

  • Docs change / refactoring / dependency upgrade

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 23, 2022
Copy link
Collaborator

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't think the perf improvement would be measurable at all compared to, say, the function call dispatch, but okay :)

@Skylion007 Skylion007 merged commit d506d13 into main Apr 24, 2022
@Skylion007 Skylion007 deleted the update-magnum-bindings branch April 24, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants