Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better identify physics object initialization crash with empty library in example.py #178

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Better identify physics object initialization crash with empty library in example.py #178

merged 2 commits into from
Aug 30, 2019

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Aug 29, 2019

Motivation and Context

"example.py --enable_physics" crashes trying to instance objects from an empty object library.

Currently, this occurs when acquiring a random objectID due to empty range in random. This fix better identifies the root of the issue as an empty library.

How Has This Been Tested

Local test.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • [ x] I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 29, 2019
@aclegg3 aclegg3 merged commit 1148f9d into master Aug 30, 2019
@aclegg3 aclegg3 deleted the physics_test_no_obj_fix branch August 30, 2019 21:00
eundersander pushed a commit to eundersander/habitat-sim that referenced this pull request Aug 6, 2020
@JasonJiazhiZhang @mathfac
Generalize performance metric for baselines (facebookresearch#178)
04368cd 
Making eval() in ppo_trainer retrieve the name (sensor_uuid) of performance metric used instead of always using spl. This change is necessary for ppo_trainer to support new tasks that might have performance metric other than spl.
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
@aclegg3
Better identify physics object initialization crash with empty librar…
88850e8 
…y in example.py (facebookresearch#178)

* Better identified physics object initialization crash with no loaded library objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikwijmans erikwijmans erikwijmans left review comments

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
Bullet-based rigid body physics
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aclegg3 @erikwijmans @facebook-github-bot