Cleanup physics things #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
aclegg3
approved these changes
Sep 4, 2019
mosra
approved these changes
Sep 4, 2019
mathfac
reviewed
Sep 5, 2019
| @@ -61,8 +61,11 @@ class Viewer : public Magnum::Platform::Application { | |||
| const Magnum::Vector2i& position); | |||
|
|
|||
| assets::ResourceManager resourceManager_; | |||
| std::shared_ptr<physics::PhysicsManager> physicsManager_; | |||
| // SceneManager must be before physicsManager_ as the physicsManager_ | |||
| // assumes that it "owns" things owned by the scene manager | |||
There was a problem hiding this comment.
Sounds like double ownership. Did you mean expect instances already initiated in SceneManager?
There was a problem hiding this comment.
No. It's kinda double ownership. The physics manager's logic is simpler if it assumes it owns the magnum scene nodes it manipulates. This is a fine thing to assume as long as the scene graph those nodes are in has a longer lifetime than the physics manager.
Ram81
pushed a commit
to Ram81/habitat-web-sim
that referenced
this pull request
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
--with-bulletalias to match the other--with-*.How Has This Been Tested
Locally
Types of changes