NavMeshSettings JSON Serialization #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Skylion007
reviewed
Oct 3, 2022
Skylion007
approved these changes
Oct 3, 2022
Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
… crosslinking (#1889) * docs: update Corrade and Magnum tagfiles so docs can link to new APIs. * docs: add convenience Doxygen aliases for inline code highlighting. * docs: update Magnum Bindings inventory file for Python crosslinking.
* Remove unused and wrong Magnum typedefs. Those have a hardcoded assumption that any mesh is a GL mesh, and that any material is a Phong material. Which is kinda true now, but it won't be going forward. Moreover, they weren't really used anywhere anyway, so there's no point in having them at all. * Don't include all of Magnum everywhere for no reason. The magnum.h header now contains SceneGraph forward declarations typedefs and only that. It doesn't and shouldn't pull in also GL or Trade stuff. * Contain Eigen into a separate header, not the main main header. It's still pulled into far too many places, but this way it can at least start getting gradually removed. * Use Magnum's forward declaration headers, not manual declarations. * Don't include MetadataMediator in Simulator.h and ResourceManager.h. Not exactly sure what is it doing, but it's quite heavy. Unfortunately most of the tests need it to set things up anyway, so it only helps partially. Also, the ::ptr typedefs are nice and all, but they mean one has to include the whole class definition. Which is not necessary in 99% of cases, so I'm converting T::ptr to the verbose std::shared_ptr<T> where a forward declaration is enough. * Remove most includes from ResourceManager.h. Wow, imagine changing anything in any of those headers. Boom, everything gets recompiled. * Stop including ResourceManager from all headers. * This is not the right way to create a string constant. The static will *copy* the string into each and every object file that directly or indirectly includes Asset.h. * Disable a useless Clang Tidy check. * Fix definition of the global logging context variable. It only worked so far because <Magnum/configure.h> was not included in Logging.cpp and so MAGNUM_BUILD_STATIC_UNIQUE_GLOBALS wasn't defined. Now it is, and the anonymous namespace is in direct conflict with the export macro.
* Habitat-lab requirements.txt has been moved to habitat-lab/habitat-lab/ directory * update requirements path in colab installer * change install from setup.py to pip * install mock manually in CI
The warning note was good enough already, but apparently those two were never used so far so they still had the dark theme colors. Also updated m.css to latest, and some other Doxyfile additions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
With expanding NavMesh use-cases it becomes useful to cache non-default settings for later reload.
Example use cases include configuring the NavMesh to generate receptacle surfaces for placing objects of a particular size or caching NavMesh parameters for a particular robot/agent embodiment. Once cached, these settings could be easily re-used in any scene/stage.
How Has This Been Tested
Added a C++ unit test.
Types of changes
Checklist