Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Support habitat-lab requirements.txt after split #1890

Merged
merged 5 commits into from
Oct 6, 2022
Merged

[bugfix] Support habitat-lab requirements.txt after split #1890

merged 5 commits into from
Oct 6, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Oct 5, 2022

Motivation and Context

With the baselines/lab split from PR 922, requirements.txt was moved. This PR updates install paths for sim testing and colab install pipelines.

Addresses #1884 and should fix broken lab test.

How Has This Been Tested

Here

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 5, 2022
@aclegg3
Copy link
Contributor Author

aclegg3 commented Oct 5, 2022

Looks like install is changed now too. Direct install with setup.py seems to no longer work, so trying to use pip setup instead.

@mosra mosra mentioned this pull request Oct 6, 2022
Merged
@aclegg3 aclegg3 merged commit 71475a5 into main Oct 6, 2022
@aclegg3 aclegg3 deleted the install-lab-split branch October 6, 2022 19:10
aclegg3 added a commit that referenced this pull request Oct 6, 2022
@aclegg3
[bugfix] Support habitat-lab requirements.txt after split (#1890)
04bdd88 
* Habitat-lab requirements.txt has been moved to habitat-lab/habitat-lab/ directory

* update requirements path in colab installer

* change install from setup.py to pip

* install mock manually in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentpierre vincentpierre vincentpierre approved these changes

@mathfac mathfac Awaiting requested review from mathfac

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @vincentpierre @facebook-github-bot