Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Physics tests: kinematics #211

Merged
merged 13 commits into from
Sep 19, 2019
Merged

Physics tests: kinematics #211

merged 13 commits into from
Sep 19, 2019

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Sep 13, 2019

Motivation and Context

New circleCI tests for physics functions introduced in PR #91

CI download test object dataset

Test initialization of default PhysicsManager and related code path for "enable_physics" flag.

Test object loading, instancing, removal, kinematics functions, etc...

How Has This Been Tested

pytest circleCI

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Testing

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 self-assigned this Sep 13, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 13, 2019
@aclegg3 aclegg3 marked this pull request as ready for review September 16, 2019 17:54
@aclegg3 aclegg3 requested review from msavva and mathfac and removed request for msavva September 16, 2019 17:54
erikwijmans
erikwijmans reviewed Sep 16, 2019
View reviewed changes
tests/test_physics.py Outdated Show resolved Hide resolved
tests/test_physics.py Outdated Show resolved Hide resolved
erikwijmans
erikwijmans reviewed Sep 18, 2019
View reviewed changes
tests/test_physics.py Outdated Show resolved Hide resolved
aclegg3 and others added 2 commits September 18, 2019 10:19
@aclegg3 @erikwijmans
Update tests/test_physics.py
a1db02a 
Remove hardcoded expected value.

Co-Authored-By: Erik Wijmans <etw@gatech.edu>
@aclegg3
Format fix
604fe30
@aclegg3
Copy link
Contributor Author

aclegg3 commented Sep 19, 2019

Any more thoughts on this one? Ready to merge.

@aclegg3 aclegg3 merged commit fd990bf into master Sep 19, 2019
@aclegg3 aclegg3 deleted the physics_tests_kinematic branch September 19, 2019 18:57
@aclegg3 aclegg3 mentioned this pull request Sep 19, 2019
Merged
12 tasks
@mathfac mathfac mentioned this pull request Jan 28, 2020
Closed
7 tasks
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
@aclegg3 @erikwijmans
Physics tests: kinematics (facebookresearch#211)
bf98553 
* Introduce kinematic physics test to circleCI

* Download object test dataset with circleCI

Co-Authored-By: Erik Wijmans <etw@gatech.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosra mosra mosra left review comments

@erikwijmans erikwijmans erikwijmans approved these changes

@mathfac mathfac Awaiting requested review from mathfac

@msavva msavva Awaiting requested review from msavva

Assignees

@aclegg3 aclegg3

Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
Bullet-based rigid body physics
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aclegg3 @mosra @erikwijmans @facebook-github-bot