Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Magnum BulletIntegration DebugDraw in viewer. #298

Merged
merged 4 commits into from
Oct 15, 2019
Merged

Enable Magnum BulletIntegration DebugDraw in viewer. #298

merged 4 commits into from
Oct 15, 2019

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Oct 15, 2019

Motivation and Context

To diagnose future Bullet physics issues, we would like to register Habitat-sim state with Bullet physics state visually. Magnum/BulletIntegration/DebugDraw provides this. This PR pulls debug functionality into the viewer demo.

How Has This Been Tested

Local testing:

Skokloster Castle:
image

CODA room:
image

Empty scene with objects:
debug_objects

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from msbaines October 15, 2019 18:12
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 15, 2019
@aclegg3 @erikwijmans
Update src/esp/physics/bullet/BulletPhysicsManager.h
129d48d 
Co-Authored-By: Erik Wijmans <etw@gatech.edu>
@aclegg3 aclegg3 mentioned this pull request Oct 15, 2019
Closed
msbaines
msbaines approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@msbaines msbaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aclegg3 aclegg3 mentioned this pull request Oct 15, 2019
Merged
11 tasks
@aclegg3 aclegg3 merged commit e214454 into master Oct 15, 2019
@aclegg3 aclegg3 deleted the bullet-debug-draw branch October 15, 2019 23:21
@aclegg3 aclegg3 mentioned this pull request Oct 16, 2019
Merged
11 tasks
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
@aclegg3
Enable Magnum BulletIntegration DebugDraw in viewer. (facebookresearc…
6b5d979 
…h#298)

* Enable Magnum BulletIntegration DebugDraw in viewer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msbaines msbaines msbaines approved these changes

@erikwijmans erikwijmans Awaiting requested review from erikwijmans

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aclegg3 @erikwijmans @msbaines @facebook-github-bot