[clang-tidy] enable clang-analyzer-cplusplus.NewDeleteLeaks

[msbaines]

• added SceneNodee:addFeature to avoid naked new

Motivation and Context

Enable static analysis to check for new/delete leaks.

How Has This Been Tested

Verified replica_v1 apartement_0 still loads with viewer.

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have completed my CLA (see CONTRIBUTING)
• I have added tests to cover my changes.
• All new and existing tests passed.

[mathfac]

Looks good. Maybe, worth to add more directories to clang-tidy scope first and then enable rules. Otherwise it will be painful to add new directories with all rules enabled. What do you think?

[msbaines]

Looks good. Maybe, worth to add more directories to clang-tidy scope first and then enable rules. Otherwise it will be painful to add new directories with all rules enabled. What do you think?

We currently run clang-tidy on all of src/esp. Was only planning on using it for our code and not deps. The only remaining directory to add it to is utils which is just two source files.

[bigbike]

I really wish I could see this diff much earlier.
I need the reference to the newly created "features" (here, the drawables) for development. And such needs are not uncommon.