Faster RGB & Depth noise models #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Skylion007
reviewed
Mar 28, 2020
| @@ -65,7 +65,7 @@ def __attrs_post_init__(self): | |||
| def _find_action(self, name): | |||
| candidates = list( | |||
| filter( | |||
| lambda v: v[1].name == name, | |||
| lambda v: name in v[1].name, | |||
There was a problem hiding this comment.
Why is this change necessary?
erikwijmans
reviewed
Mar 28, 2020
| @@ -65,7 +65,7 @@ def __attrs_post_init__(self): | |||
| def _find_action(self, name): | |||
| candidates = list( | |||
| filter( | |||
| lambda v: v[1].name == name, | |||
| lambda v: name in v[1].name, | |||
There was a problem hiding this comment.
This is a little dangerous as things are assumed to be deterministic in the follower, but #546 will subsume this, so fine.
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
==========================================
- Coverage 63.79% 63.75% -0.04%
==========================================
Files 162 162
Lines 7880 7878 -2
Branches 84 84
==========================================
- Hits 5027 5023 -4
- Misses 2853 2855 +2
Continue to review full report at Codecov.
|
|
Removed greedy_geodesic_follower change. |
erikwijmans
approved these changes
Mar 28, 2020
Ram81
pushed a commit
to Ram81/habitat-web-sim
that referenced
this pull request
Dec 10, 2020
We noticed that RGB noise models are 7x times slower than whole Habitat step call. @erikwijmans with @Skylion007 made our RGB noise models 50x faster with following PR. One minor change is to make GreedyFollower compatible with PyRobot actions. The change makes it possible to build shortest path on the fly with noise actuations.
luoj1
pushed a commit
to luoj1/habitat-sim
that referenced
this pull request
Aug 16, 2022
* Support properties/members with call_at * Use named consts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We noticed that RGB noise models are 7x times slower than whole Habitat step call.
@erikwijmans with @Skylion007 made our RGB noise models 50x faster with following PR.
How Has This Been Tested
Existing HSIM noise tests, HAPI noise tests.
Types of changes