Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python bindings: get/set velocity #591

Merged
merged 9 commits into from
Apr 15, 2020
Merged

python bindings: get/set velocity #591

merged 9 commits into from
Apr 15, 2020

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Apr 15, 2020

Motivation and Context

This PR completes #565 with modified python testing.

How Has This Been Tested

New test statements in tests/test_physics.py.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from jturner65 April 15, 2020 16:09
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 15, 2020
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #591 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #591      +/-   ##
==========================================
+ Coverage   56.50%   56.56%   +0.06%     
==========================================
  Files         128      128              
  Lines        5612     5620       +8     
  Branches       84       84              
==========================================
+ Hits         3171     3179       +8     
  Misses       2441     2441              
Flag Coverage Δ
#CPP 52.03% <ø> (ø)
#JavaScript 10.00% <ø> (ø)
#Python 75.64% <100.00%> (+0.09%) ⬆️
Impacted Files Coverage Δ
src/esp/sim/Simulator.h 100.00% <ø> (ø)
habitat_sim/simulator.py 96.04% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321a3b2...a5ad2e5. Read the comment docs.

@aclegg3 aclegg3 merged commit 61931bc into master Apr 15, 2020
@aclegg3 aclegg3 deleted the getset-vel-bindings branch April 15, 2020 18:13
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
* python binding for velocity based object control

Co-authored-by: pushkalkatara <katarapushkal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants