Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ax Sweeper Plugin support for Python 3.11 #2777

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Pedrexus
Copy link

Motivation

Ax Sweeper Plugin is now being supported in python 3.11 and Ax 0.3.4

Have you read the Contributing Guidelines on pull requests?

Yes

Test Notes

There were multiple warning being raised by internal dependencies of the Ax library, which can only be worked out with one or more updates in that library.

Related Issues and PRs

#2489

@facebook-github-bot
Copy link
Contributor

Hi @Pedrexus!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 28, 2023
@Jasha10
Copy link
Collaborator

Jasha10 commented Dec 24, 2023

Looks like there are a few linter failures on the test_linux-3.11 CI:

nox > [2023-12-23 01:31:44,791] Command black . --check failed with exit code 1:
Skipping .ipynb files as Jupyter dependencies are not installed.
You can fix this by running ``pip install "black[jupyter]"``
would reformat /home/circleci/project/plugins/hydra_ax_sweeper/setup.py
would reformat /home/circleci/project/plugins/hydra_ax_sweeper/hydra_plugins/hydra_ax_sweeper/config.py
would reformat /home/circleci/project/plugins/hydra_ax_sweeper/tests/test_ax_sweeper_plugin.py
nox > [2023-12-23 01:38:03,593] flake8 --config .flake8 /home/circleci/project/plugins/hydra_ax_sweeper
/home/circleci/project/plugins/hydra_ax_sweeper/setup.py:36:1: W391 blank line at end of file
/home/circleci/project/plugins/hydra_ax_sweeper/hydra_plugins/hydra_ax_sweeper/config.py:9:1: E302 expected 2 blank lines, found 1
/home/circleci/project/plugins/hydra_ax_sweeper/tests/test_ax_sweeper_plugin.py:25:120: E501 line too long (196 > 119 characters)
/home/circleci/project/plugins/hydra_ax_sweeper/tests/test_ax_sweeper_plugin.py:70:1: E302 expected 2 blank lines, found 1
/home/circleci/project/plugins/hydra_ax_sweeper/tests/test_ax_sweeper_plugin.py:152:1: E302 expected 2 blank lines, found 1
/home/circleci/project/plugins/hydra_ax_sweeper/tests/test_ax_sweeper_plugin.py:177:1: E302 expected 2 blank lines, found 1
/home/circleci/project/plugins/hydra_ax_sweeper/tests/test_ax_sweeper_plugin.py:204:1: E302 expected 2 blank lines, found 1
/home/circleci/project/plugins/hydra_ax_sweeper/tests/test_ax_sweeper_plugin.py:235:1: E302 expected 2 blank lines, found 1
/home/circleci/project/plugins/hydra_ax_sweeper/tests/test_ax_sweeper_plugin.py:310:1: E302 expected 2 blank lines, found 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants