Replace pkg_resource based config source with importlib_resources based one #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
omry
force-pushed
the
importlib-resources
branch
from
1868017
to
219bfaf
Compare
omry
force-pushed
the
importlib-resources
branch
2 times, most recently
from
fed8381
to
89fd7ae
Compare
omry
force-pushed
the
importlib-resources
branch
2 times, most recently
from
0e9ee23
to
bc1471b
Compare
omry
changed the title
omry
force-pushed
the
importlib-resources
branch
3 times, most recently
from
f601511
to
91de44f
Compare
omry
force-pushed
the
importlib-resources
branch
from
91de44f
to
e1304eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_resources has some issues with pytest plugins and is generally considered slow.
This replaces it with the future compatible importlib_resources package (which will be a part of Python 3.9 as importlib.resources).
In addition, this kills the hydra-pytest-plugin and makes hydra-core provide the fixtures directly (this is now possible due to using importlib_resources).
Closes #719
Closes #717