-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome, thanks a lot!
I have some minor comments, and one remark about the timing of the forward during inference.
Note that adding a torch.cuda.synchronize()
could potentially slow down a bit, but that should be verified.
# gn | ||
"gn_baselines/e2e_faster_rcnn_R_50_FPN_1x_gn.yaml", | ||
# TODO: fail to run for random model due to empty head input | ||
# "gn_baselines/e2e_mask_rcnn_R_50_FPN_Xconv1fc_1x_gn.yaml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you expand on why those two cases fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed to fail when no input to the keypoint head. The error message is follow:
File "/Users/stzpz/code/newstzpz/forked/maskrcnn-benchmark/maskrcnn_benchmark/modeling/roi_heads/roi_heads.py", line 53, in forward
x, detections, loss_keypoint = self.keypoint(keypoint_features, detections, targets)
File "/anaconda3/envs/maskrcnn_benchmark/lib/python3.7/site-packages/torch/nn/modules/module.py", line 491, in __call__
result = self.forward(*input, **kwargs)
File "/Users/stzpz/code/newstzpz/forked/maskrcnn-benchmark/maskrcnn_benchmark/modeling/roi_heads/keypoint_head/keypoint_head.py", line 42, in forward
result = self.post_processor(kp_logits, proposals)
File "/anaconda3/envs/maskrcnn_benchmark/lib/python3.7/site-packages/torch/nn/modules/module.py", line 491, in __call__
result = self.forward(*input, **kwargs)
File "/Users/stzpz/code/newstzpz/forked/maskrcnn-benchmark/maskrcnn_benchmark/modeling/roi_heads/keypoint_head/inference.py", line 15, in forward
mask_prob, scores = self.keypointer(x, boxes)
File "/Users/stzpz/code/newstzpz/forked/maskrcnn-benchmark/maskrcnn_benchmark/modeling/roi_heads/keypoint_head/inference.py", line 114, in __call__
assert len(boxes) == 1
AssertionError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks!
I'll see if I fix this in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed to fail when no input to the keypoint head. The error message is follow:
File "/Users/stzpz/code/newstzpz/forked/maskrcnn-benchmark/maskrcnn_benchmark/modeling/roi_heads/roi_heads.py", line 53, in forward x, detections, loss_keypoint = self.keypoint(keypoint_features, detections, targets) File "/anaconda3/envs/maskrcnn_benchmark/lib/python3.7/site-packages/torch/nn/modules/module.py", line 491, in __call__ result = self.forward(*input, **kwargs) File "/Users/stzpz/code/newstzpz/forked/maskrcnn-benchmark/maskrcnn_benchmark/modeling/roi_heads/keypoint_head/keypoint_head.py", line 42, in forward result = self.post_processor(kp_logits, proposals) File "/anaconda3/envs/maskrcnn_benchmark/lib/python3.7/site-packages/torch/nn/modules/module.py", line 491, in __call__ result = self.forward(*input, **kwargs) File "/Users/stzpz/code/newstzpz/forked/maskrcnn-benchmark/maskrcnn_benchmark/modeling/roi_heads/keypoint_head/inference.py", line 15, in forward mask_prob, scores = self.keypointer(x, boxes) File "/Users/stzpz/code/newstzpz/forked/maskrcnn-benchmark/maskrcnn_benchmark/modeling/roi_heads/keypoint_head/inference.py", line 114, in __call__ assert len(boxes) == 1 AssertionError
Can you tell me how to solve this problem? We look forward to your reply.thanks a lot
08e6d1c
to
b41fb15
Compare
b41fb15
to
2032c5a
Compare
i have a suggestion: make a folder |
I have a question, why does Fbnet not use FPN? Would it be ineffective to detect small objects? |
I've updated the README with the pre-trained models for Detection. Thanks a lot @newstzpz ! |
* Added a timer to benchmark model inference time in addition to total runtime. * Updated FBNet configs and included some baselines benchmark results. * Added a unit test for detectors. * Add links to the models
FBNet benchmark
We provided pre-trained models for selected FBNet models.
MODEL.RPN.POST_NMS_TOP_N_TEST
set to200
.The following inference time is reported:
The pre-trained models are available in the link in the model id.