Add warning for trace_link script when annotation is not present, fix write for gzip files #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancoutinho
requested review from
srinivas212,
kingchc,
louisfeng,
sunghlin,
wfu-fb and
shengbao-zheng
as code owners
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48038506 |
… write for gzip files (facebookresearch#83) Summary: Pull Request resolved: facebookresearch#83 1. Add a warning when annotation is not found 2. Support writing json to gzip files Reviewed By: TaekyungHeo Differential Revision: D48038506 fbshipit-source-id: 8e0bfc7f6a0a18c95703dc23407c9f5da20fade4
briancoutinho
force-pushed
the
export-D48038506
branch
from
5495e12
to
ec7ff35
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48038506 |
|
This pull request has been merged in 40ffa8f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D48038506