Some cleanups to the model spec documentation. #27
Conversation
Clarify Android-only support for certain types. Clean up descriptions of certain elements in the spec. Fix a few typos.
|
Hi @mdwelsh! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@raedle has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
We've merged the PR. Thanks again for your contributions, @mdwelsh!! |
Summary: Clarify Android-only support for certain types. Clean up descriptions of certain elements in the spec. Fix a few typos. The model spec documentation is confusing in a few cases, and some types are not supported on iOS (see #26). ## Changelog [DOCS] Improve model spec documentation Pull Request resolved: #27 Test Plan: There are no code changes in this PR. **Static Docs Preview: pytorch-live** |[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D33418396/V3/pytorch-live/)| |**Modified Pages**| |[docs/tutorials/model-spec](https://our.intern.facebook.com/intern/staticdocs/eph/D33418396/V3/pytorch-live/docs/tutorials/model-spec/)| |[docs/api/model-spec](https://our.intern.facebook.com/intern/staticdocs/eph/D33418396/V3/pytorch-live/docs/api/model-spec/)| Reviewed By: clarksandholtz Differential Revision: D33418396 Pulled By: raedle fbshipit-source-id: 1d154f4f58b1a634f5d3b732b05647a73e2a0208
Clarify Android-only support for certain types.
Clean up descriptions of certain elements in the spec.
Fix a few typos.
Summary
The model spec documentation is confusing in a few cases, and some types are not supported on iOS (see #26).
Changelog
[DOCS] Improve model spec documentation
Test Plan
There are no code changes in this PR.