This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix zero loss tensor in SquadOutputLayer #1181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D18801364 |
Summary: Pull Request resolved: #1181 In SquadOutputLayer we set start and end position losses to zeros. Those tensor objects have `requires_grad` set to True which leads to unused param error. ``` RuntimeError: Expected to have finished reduction in the prior iteration before starting a new one. This error indicates that your module has parameters that were not used in producing loss. ``` Reviewed By: borguz Differential Revision: D18801364 fbshipit-source-id: 400a56b453a85939f8428b378e42e5238cc241e9
|
This pull request was exported from Phabricator. Differential Revision: D18801364 |
|
This pull request has been merged in ae807e2. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In SquadOutputLayer we set start and end position losses to zeros. Those tensor objects have
requires_gradset to True which leads to unused param error.Reviewed By: borguz
Differential Revision: D18801364