This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
If the snapshot path provided is not valid, throw error #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: It was silently failing when i was trying to load a file from gluster. Shouldnt it throw error if the file is not readable? Created from Diffusion's 'Open in Editor' feature. ``` config.load_snapshot_path : /mnt/vol/gfsfblearner-east3/flow/data/2020-02-27/4167d473-9a3a-4198-82b1-153c4db14afd/171027009/5924195916406591978/model.pt PathManager.isfile(config.load_snapshot_path) : False ``` Reviewed By: hudeven Differential Revision: D20144757 fbshipit-source-id: e1743dc009fde3ac29fb302b46e043f5691d1d48
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D20144757 |
|
This pull request has been merged in 7eef977. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It was silently failing when i was trying to load a file from gluster. Shouldnt it throw error if the file is not readable?
Created from Diffusion's 'Open in Editor' feature.
Reviewed By: hudeven
Differential Revision: D20144757