This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Documentation on the config files and config-related commands #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@Titousensei has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Titousensei
force-pushed
the
cfg_doc
branch
from
ae5f8de
to
3d49c3c
Compare
|
@Titousensei has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@Titousensei has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Titousensei
force-pushed
the
cfg_doc
branch
from
3d49c3c
to
ce49208
Compare
|
@Titousensei has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@Titousensei has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 24, 2019
Summary: ## Motivation and Context PyText uses json config files, but there's no documentation on how to create and modify them. ## How Has This Been Tested Read the generated docs in circleCI ## Types of changes - [x] Docs change / refactoring / dependency upgrade - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [x] I have updated the documentation accordingly. - [x] I have read the **CONTRIBUTING** document. - [x] I have completed my CLA (see **CONTRIBUTING**) - [ ] I have added tests to cover my changes. - [x] All new and existing tests passed. Pull Request resolved: #984 Test Plan: Look at the circleci artifacts for built documentation `config_commands.html` and `config_files.html`. https://13610-143080897-gh.circle-artifacts.com/0/docs/config_commands.html https://13610-143080897-gh.circle-artifacts.com/0/docs/config_files.html Reviewed By: rutyrinott Differential Revision: D17413280 Pulled By: Titousensei fbshipit-source-id: b5cae927687942f3dd0f50907ae4f04ec236c4ab
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
PyText uses json config files, but there's no documentation on how to create and modify them.
How Has This Been Tested
Read the generated docs in circleCI
Types of changes
Checklist