This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
EASY [PyText] Demo datasource fix + cleanup #994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - fix the intent vocab lookup by adding reader_raw to read the line and lookup the only token in the vocab (as opposed to query reader that removes BOS/EOS) - cleanup duplicate constants in Config and __init__. Differential Revision: D17535325 fbshipit-source-id: 66c59eaf2f18738a7ceab136d7c88aea2d768a50
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 24, 2019
Summary: Pull Request resolved: #994 - fix the intent vocab lookup by adding reader_raw to read the line and lookup the only token in the vocab (as opposed to query reader that removes BOS/EOS) - cleanup duplicate constants in Config and __init__. Reviewed By: snisarg Differential Revision: D17535325 fbshipit-source-id: 4b8a242f5c610d598f7b04c218152859ccbc7d43
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
lookup the only token in the vocab (as opposed to query reader that removes
BOS/EOS)
Differential Revision: D17535325